Skip to content

MONGOID-5872 - [🛠️ Let's Fix Mongoid's Broken CI] DocumentNotFound spec on Ruby 3.4 #5983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

johnnyshields
Copy link
Contributor

Hash#inspect changed in Ruby 3.4

@johnnyshields johnnyshields requested a review from a team as a code owner May 12, 2025 06:50
@johnnyshields johnnyshields requested a review from jamis May 12, 2025 06:50
@johnnyshields johnnyshields changed the title Fix DocumentNotFound spec on Ruby 3.4 Let's Fix Mongoid's Broken CI: DocumentNotFound spec on Ruby 3.4 May 12, 2025
@johnnyshields johnnyshields changed the title Let's Fix Mongoid's Broken CI: DocumentNotFound spec on Ruby 3.4 [Let's Fix Mongoid's Broken CI] DocumentNotFound spec on Ruby 3.4 May 12, 2025
@johnnyshields johnnyshields changed the title [Let's Fix Mongoid's Broken CI] DocumentNotFound spec on Ruby 3.4 [🛠️ Let's Fix Mongoid's Broken CI] DocumentNotFound spec on Ruby 3.4 May 12, 2025
@johnnyshields johnnyshields changed the title [🛠️ Let's Fix Mongoid's Broken CI] DocumentNotFound spec on Ruby 3.4 MONGOID-5872 - [🛠️ Let's Fix Mongoid's Broken CI] DocumentNotFound spec on Ruby 3.4 May 12, 2025
@jamis
Copy link
Contributor

jamis commented May 22, 2025

Hey Johnny, we've got https://jira.mongodb.org/browse/MONGOID-5812 that will specifically address Ruby 3.4 support. For now, we don't officially support Ruby 3.4 yet.

@jamis jamis closed this May 22, 2025
@johnnyshields
Copy link
Contributor Author

johnnyshields commented May 23, 2025

@jamis I'm pretty sure this is the only PR that is needed to support Ruby 3.4, aside from adding it to the CI. The tests pass otherwise, and I'm already running Mongoid on Ruby 3.4 in production. How about reopening and renaming the title to MONGOID-5812?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants